[PATCH 09/20] staging: octeon-usb: cvmx-usb: replace long udelays with mdelays
Aaro Koskinen
aaro.koskinen at iki.fi
Mon Jul 29 18:10:03 UTC 2013
Hi,
On Mon, Jul 29, 2013 at 07:52:14PM +0200, Andi Shyti wrote:
> > - cvmx_wait_usec(1000);
> > + mdelay(1);
>
> why not udelay here?
It's long enough so that mdelay can be used. :)
> > - cvmx_wait_usec(50000);
> > + mdelay(50);
>
> and why not msleep here?
cvmx_usb_enable() is called holding a spinlock with interrupts disabled.
We cannot sleep here.
A.
More information about the devel
mailing list