[PATCH -next] staging: gdm724x: use GFP_ATOMIC under spin lock
Dan Carpenter
dan.carpenter at oracle.com
Fri Jul 26 07:32:33 UTC 2013
On Fri, Jul 26, 2013 at 10:15:55AM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei at trendmicro.com.cn>
>
> A spin lock is taken here so we should use GFP_ATOMIC.
>
Acked-by: Dan Carpenter <dan.carpenter at oracle.com>
But the locking here is really odd and pointless. usb_submit_urb()
returns asynchronously before the data has been sent, so there is
almost no point in locking around it.
regards,
dan carpenter
More information about the devel
mailing list