[PATCH 00/53] staging: comedi: usbdux: cleanup driver

H Hartley Sweeten hartleys at visionengravers.com
Thu Jul 25 17:08:20 UTC 2013


On Thursday, July 25, 2013 8:25 AM, Ian Abbott wrote:
> On 2013-07-24 22:05, H Hartley Sweeten wrote:
>> Move all the usb_driver (*probe) and (*disconnect) operations into the
>> comedi_driver (*auto_attach) and (*detach). This allows the per device
>> private data to be kzalloc()'d and removes the 16 device limitation.
>>
>> Remove all the unnecessary information from the private data.
>>
>> Tidy up the driver to remove any cruft.
>>
>> H Hartley Sweeten (53):

<snip>

> I commented on patches 33, 34, 39, 40 and 47 to do with the ordering of 
> setting the foo_cmd_start variables and submitting the URBs, but the 
> remaining look okay.

I'll rebase this series and drop those changes.

> I wish I'd noticed the ordering problem when the patches for usbduxfast 
> and usbduxsigma were submitted!

I'll need to fix those as well.

I'm hoping to merge the usbdux* drivers. They are all _very_ similar. The
Only real differences appears to be low-level data packets sent to the usb
device. I'm still trying to unwind it.

Thanks,
Hartley




More information about the devel mailing list