[PATCH 06/13] staging: comedi: pcmuio: pcmuio_handle_asic_interrupt() does not need the subdevice
H Hartley Sweeten
hartleys at visionengravers.com
Thu Jul 25 16:37:19 UTC 2013
On Thursday, July 25, 2013 5:50 AM, Ian Abbott wrote:
> On 2013-07-24 19:47, H Hartley Sweeten wrote:
>> The comedi_subdevice pointer is not used in this function. Its simply
>> passed on to pcmuio_handle_intr_subdev(). That function then needs to
>> calculate the 'asic' associated with the subdevice. Just pass on the
>> 'asic' instead and let pcmuio_handle_intr_subdev() get the subdevice
>> from that.
>>
>> Signed-off-by: H Hartley Sweeten <hsweeten at visionengravers.com>
>> Cc: Ian Abbott <abbotti at mev.co.uk>
>> Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
>
> In that case, it would make sense to rename the function to
> pcmuio_handle_intr_asic().
Or just pcmuio_handle_pending_intr(), then the comment could also be
removed.
This could be a separate patch. But I can rebase the series it you wish.
Regards,
Hartley
More information about the devel
mailing list