[PATCH 00/14] staging: comedi: ii_pci20kc: cleanup driver

Ian Abbott abbotti at mev.co.uk
Thu Jul 25 14:25:16 UTC 2013


On 2013-07-24 20:08, H Hartley Sweeten wrote:
> Tidy up this legacy comedi driver.
>
> H Hartley Sweeten (14):
>    staging: comedi: ii_pci20kc: use comedi_alloc_spriv()
>    staging: comedi: ii_pci20kc: remove forward declarations 1
>    staging: comedi: ii_pci20kc: remove forward declarations 2
>    staging: comedi: ii_pci20kc: remove forward declarations 3
>    staging: comedi: ii_pci20kc: move comedi_lrange tables
>    staging: comedi: ii_pci20kc: remove CHAN macro
>    staging: comedi: ii_pci20kc.c: cleanup the dio subdevice
>    staging: comedi: ii_pci20kc.c: tidy up the subdevice module init
>    staging: comedi: ii_pci20kc.c: remove 'iobase' from the subdevice private data
>    staging: comedi: ii_pci20kc.c: break up the subdevice private data union
>    staging: comedi: ii_pci20kc: cleanup the ao subdevice
>    staging: comedi: ii_pci20kc: cleanup the ai subdevice
>    staging: comedi: ii_pci20kc: cleanup final pieces
>    staging: comedi: ii_pci20kc: reorder subdevices
>
>   drivers/staging/comedi/drivers/ii_pci20kc.c | 1002 ++++++++++++---------------
>   1 file changed, 443 insertions(+), 559 deletions(-)

I only commented on patch 14 (reordering the subdevices) although I 
don't know enough about the hardware to comment on patch 12 (handling 
multiple AI ranges).

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti at mev.co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-


More information about the devel mailing list