[PATCH 06/13] staging: comedi: pcmuio: pcmuio_handle_asic_interrupt() does not need the subdevice

Ian Abbott abbotti at mev.co.uk
Thu Jul 25 12:49:34 UTC 2013


On 2013-07-24 19:47, H Hartley Sweeten wrote:
> The comedi_subdevice pointer is not used in this function. Its simply
> passed on to pcmuio_handle_intr_subdev(). That function then needs to
> calculate the 'asic' associated with the subdevice. Just pass on the
> 'asic' instead and let pcmuio_handle_intr_subdev() get the subdevice
> from that.
>
> Signed-off-by: H Hartley Sweeten <hsweeten at visionengravers.com>
> Cc: Ian Abbott <abbotti at mev.co.uk>
> Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>

In that case, it would make sense to rename the function to 
pcmuio_handle_intr_asic().

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti at mev.co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-


More information about the devel mailing list