[PATCH] staging: comedi: allow ISA and PC/104 drivers on non-ISA systems

[Ian Abbott]

On 2013-07-24 19:24, H Hartley Sweeten wrote:
> Embedded systems with a PC/104 bus might have a configuration that
> does not have ISA enabled. This creates a problem in Comedi where
> the PC/104 drivers cannot be enabled.
>
> Introduce a Kconfig option to allow enabling the Comedi ISA and
> PC/104 drivers if ISA is disabled.
>
> Signed-off-by: H Hartley Sweeten <hsweeten at visionengravers.com>
> Cc: Ian Abbott <abbotti at mev.co.uk>
> Cc: Greg Kroah-Hartman <gregkh at linuxfondation.org>
> ---
>   drivers/staging/comedi/Kconfig | 13 ++++++++++++-
>   1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/Kconfig b/drivers/staging/comedi/Kconfig
> index 01782fc..4a5dc4c 100644
> --- a/drivers/staging/comedi/Kconfig
> +++ b/drivers/staging/comedi/Kconfig
> @@ -98,9 +98,20 @@ config COMEDI_SKEL
>
>   endif # COMEDI_MISC_DRIVERS
>
> +if !ISA
> +
> +config COMEDI_ENABLE_ISA
> +	bool "Enable Comedi ISA and PC/104 drivers on non-ISA systems"
> +	---help---
> +	  Many of the Comedi PC/104 drivers work on embeded systems that
> +	  might not have the ISA option enabled. Select this option to
> +	  enable Comedi ISA and PC/104 drivers on these systems.
> +
> +endif # !ISA
> +
>   menuconfig COMEDI_ISA_DRIVERS
>   	bool "Comedi ISA and PC/104 drivers"
> -	depends on ISA
> +	depends on ISA || COMEDI_ENABLE_ISA
>   	---help---
>   	  Enable comedi ISA and PC/104 drivers to be built
>
>

I know there are one or two PC/104-Plus CPU boards with 64-bit 
processors that have a PC/104 ISA bus, but I don't know how well PC/104 
ISA boards work on such systems when run in 64-bit mode.  Is it worth 
worrying about them?

If you just want the option to build-test the ISA drivers, there is a 
COMPILE_TEST configuration option that could be checked, e.g.:

menuconfig COMEDI_ISA_DRIVERS
	bool "Comedi ISA and PC/104 drivers"
	depends on ISA || COMPILE_TEST
   	---help---
   	  Enable comedi ISA and PC/104 drivers to be built

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti at mev.co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-