[PATCH 04/12] staging: comedi: quatech_daqp_cs: remove daqp_cs_release()

H Hartley Sweeten hartleys at visionengravers.com
Fri Jan 25 21:59:36 UTC 2013


This function justs emits a dev_dbg() message then calls
pcmcia_disable_device(). The dev_dbg() is just added noise.

Remove the function and just call pcmcia_disable_device().

Signed-off-by: H Hartley Sweeten <hsweeten at visionengravers.com>
Cc: Ian Abbott <abbotti at mev.co.uk>
Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
---
 drivers/staging/comedi/drivers/quatech_daqp_cs.c | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

diff --git a/drivers/staging/comedi/drivers/quatech_daqp_cs.c b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
index 748aa6a..b2b755f 100644
--- a/drivers/staging/comedi/drivers/quatech_daqp_cs.c
+++ b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
@@ -936,13 +936,6 @@ static int daqp_cs_resume(struct pcmcia_device *link)
 	return 0;
 }
 
-static void daqp_cs_release(struct pcmcia_device *link)
-{
-	dev_dbg(&link->dev, "daqp_cs_release\n");
-
-	pcmcia_disable_device(link);
-}
-
 static int daqp_pcmcia_config_loop(struct pcmcia_device *p_dev, void *priv_data)
 {
 	if (p_dev->config_index == 0)
@@ -976,7 +969,7 @@ static void daqp_cs_config(struct pcmcia_device *link)
 	return;
 
 failed:
-	daqp_cs_release(link);
+	pcmcia_disable_device(link);
 }
 
 static int daqp_cs_attach(struct pcmcia_device *link)
@@ -1014,7 +1007,7 @@ static void daqp_cs_detach(struct pcmcia_device *link)
 	struct local_info_t *dev = link->priv;
 
 	dev->stop = 1;
-	daqp_cs_release(link);
+	pcmcia_disable_device(link);
 
 	/* Unlink device structure, and free it */
 	dev_table[dev->table_index] = NULL;
-- 
1.8.0.2




More information about the devel mailing list