lib/devres.c:116:3: error: implicit declaration of function 'ERR_PTR'

[Thierry Reding]

On Tue, Jan 22, 2013 at 12:45:57PM -0800, Greg Kroah-Hartman wrote:
> On Wed, Jan 23, 2013 at 04:25:16AM +0800, kbuild test robot wrote:
> > tree:   git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git driver-core-next
> > head:   75096579c3ac39ddc2f8b0d9a8924eba31f4d920
> > commit: 75096579c3ac39ddc2f8b0d9a8924eba31f4d920 lib: devres: Introduce devm_ioremap_resource()
> > date:   3 hours ago
> > config: make ARCH=openrisc or1ksim_defconfig
> > 
> > All error/warnings:
> > 
> >    lib/devres.c: In function 'devm_ioremap_resource':
> > >> lib/devres.c:116:3: error: implicit declaration of function 'ERR_PTR'
> > >> lib/devres.c:116:3: warning: return makes pointer from integer without a cast
> >    lib/devres.c:124:3: warning: return makes pointer from integer without a cast
> > >> lib/devres.c:135:12: warning: assignment makes pointer from integer without a cast
> >    lib/devres.c: In function 'devm_request_and_ioremap':
> > >> lib/devres.c:163:2: error: implicit declaration of function 'IS_ERR'
> > 
> > vim +/ERR_PTR +116 lib/devres.c
> > 
> >    110		void __iomem *dest_ptr;
> >    111	
> >    112		BUG_ON(!dev);
> >    113	
> >    114		if (!res || resource_type(res) != IORESOURCE_MEM) {
> >    115			dev_err(dev, "invalid resource\n");
> >  > 116			return ERR_PTR(-EINVAL);
> 
> Thierry, care to send me a patch to add err.h to this file to fix this
> error?

I build tested ARM and MIPS and didn't see this problem. It seems like I
need to get myself an OpenRISC toolchain. =)

Patch sent. Thanks for catching this.

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/attachments/20130122/66d7ed75/attachment.asc>