[PATCH] staging: comedi: Allow comedi on ARM

H Hartley Sweeten hartleys at visionengravers.com
Mon Jan 21 18:19:38 UTC 2013


On Monday, January 21, 2013 10:21 AM, Ian Abbott wrote:
> Bernd Porr reports success getting comedi to work on ARM.  He writes:
>
> """
> comedi works nicely on the Raspberry PI. I've compiled the rpi kernel
> with comedi enabled and it works with the USBDUX-sigma (need to test the
> other boards). With comedirecord running I can plot one channel at 1kHz
> without buffer overflow (resulting to 70% load).

Great news!

> So, I guess we just need to add "ARM" to Kconfig in the comedi subdir?
>
>          depends on BROKEN || FRV || M32R || MN10300 || SUPERH || TILE || X86 || ARM
>
> I'm running just now 3.2.27 but also the development kernel compiles
> with ARM enabled (haven't tested yet).
>
> /Bernd
> """
>
> Enable the COMEDI config option to be selected for ARM.
>
> Signed-off-by: Ian Abbott <abbotti at mev.co.uk>
> Cc: Bernd Porr <mail at berndporr.me.uk>
> ---
>  drivers/staging/comedi/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/Kconfig b/drivers/staging/comedi/Kconfig
> index 39cf735..081e994 100644
> --- a/drivers/staging/comedi/Kconfig
> +++ b/drivers/staging/comedi/Kconfig
> @@ -1,7 +1,8 @@
>  config COMEDI
>  	tristate "Data acquisition support (comedi)"
>  	depends on m
> -	depends on BROKEN || FRV || M32R || MN10300 || SUPERH || TILE || X86
> +	depends on BROKEN || FRV || M32R || MN10300 || SUPERH || TILE || \
> +		   X86 || ARM

The depends on is getting a bit long. What is the actual issue that drives this? Is it
just a matter of getting test exposure for the different architectures?

Also, do you know why COMEDI depends on 'm'? Is it possible to have comedi built-in
to a kernel?

Regards,
Hartley





More information about the devel mailing list