[PATCH 15/23] staging: comedi: introduce addi_watchdog driver

[Ian Abbott]

On 2013-01-16 16:16, H Hartley Sweeten wrote:
> On Wednesday, January 16, 2013 3:46 AM, Ian Abbott wrote:
>> On 2013-01-16 00:43, H Hartley Sweeten wrote:
>>> diff --git a/drivers/staging/comedi/Kconfig b/drivers/staging/comedi/Kconfig
>>> index 36eec32..8f2bef3 100644
>>> --- a/drivers/staging/comedi/Kconfig
>>> +++ b/drivers/staging/comedi/Kconfig
>>> @@ -567,6 +567,13 @@ config COMEDI_8255_PCI
>>>    	  To compile this driver as a module, choose M here: the module will
>>>    	  be called 8255_pci.
>>>
>>> +config COMEDI_ADDI_WATCHDOG
>>> +	tristate
>>> +	---help---
>>> +	  Provides support for the watchdog subdevice found on many ADDI-DATA
>>> +	  boards. This module will be automatically selected when needed. The
>>> +	  module will be called addi_watchdog.
>>> +
>>
>> I don't think this needs to be a user-selectable option, so the
>> '--help--' section could be removed to hide the option from the
>> interactive kernel config editor.
>
> The option is still hidden due to no prompt text after the 'tristate'.

Oh, that's okay then.

> I added the help section just to explain what the config option is meant for.
> There are a number of hidden options in the kernel that I personally wish had
> some kind of explanation...

Maybe a # comment would be better in those cases, though I suppose the 
---help-- is useful on the off-chance it may become a user-selectable 
option in the future.

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti at mev.co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-