[PATCH] staging: comedi: pass through context for USB/PCI auto attach
Greg Kroah-Hartman
gregkh at linuxfoundation.org
Mon Jan 7 22:14:56 UTC 2013
On Tue, Dec 04, 2012 at 04:28:11PM +0000, Ian Abbott wrote:
> On 2012-12-04 14:10, Dan Carpenter wrote:
> >You guys have taken some unused code and made it more and more
> >flexible. I think you should just delete the parameter. When you
> >need a parameter, then we can add it back. If you need two
> >parameters then we can add two of them.
>
> The one current driver that might have a use for it is the vmk80xx
> driver. That one has `driver_info` values in its USB device table,
> but the driver currently uses that in its USB probe routine to
> allocate and initialize a load of stuff before it calls
> comedi_usb_auto_config(). If the driver was changed to remove the
> manual attachment functionality (the `attach` handler), I think all
> that stuff could be moved to the `auto_attach` handler, in which
> case setting the context parameter to the `driver_info` value would
> be useful.
Yeah, but to force this extra parameter on all other drivers just
because one could use it, isn't the nicest.
I'd prefer the driver_info use if at all possible, as that's what it is
there for. So I'd like to not apply either of the patches in this
thread, ok?
thanks,
greg k-h
More information about the devel
mailing list