[PATCH 1/2] staging: et131x: Replace rxdma csr register magic numbers with defines

Dan Carpenter dan.carpenter at oracle.com
Thu Jan 3 14:21:48 UTC 2013


On Sun, Dec 30, 2012 at 08:26:54PM +0000, mark.einon at gmail.com wrote:
> @@ -881,15 +880,16 @@ static void et131x_rx_dma_disable(struct et131x_adapter *adapter)
>  {
>  	u32 csr;
>  	/* Setup the receive dma configuration register */
> -	writel(0x00002001, &adapter->regs->rxdma.csr);
> +	writel(ET_RXDMA_CSR_HALT | ET_RXDMA_CSR_FBR0_ENABLE,
> +	       &adapter->regs->rxdma.csr);
>  	csr = readl(&adapter->regs->rxdma.csr);

This is a behavior change.  ET_RXDMA_CSR_FBR1_ENABLE was intended
instead of ET_RXDMA_CSR_FBR0_ENABLE.

> +#define ET_RXDMA_CSR_FBR0_ENABLE	0x0400
> +#define ET_RXDMA_CSR_FBR1_ENABLE	0x2000

regards,
dan carpenter



More information about the devel mailing list