[PATCH] rtl8712: remove redundant if statement

Larry Finger Larry.Finger at lwfinger.net
Wed Feb 27 21:27:25 UTC 2013


On 02/27/2013 01:40 PM, Niklas Söderlund wrote:
> Same result no matter what path is taken.
>
> Signed-off-by: Niklas Söderlund <niso at kth.se>
> ---
>   drivers/staging/rtl8712/rtl8712_led.c | 8 ++------
>   1 file changed, 2 insertions(+), 6 deletions(-)

I just reviewed all versions of the vendor driver, and this has never been changed.

Acked-by: Larry Finger <Larry.Finger at lwfinger.net>

Thanks,

Larry

>
> diff --git a/drivers/staging/rtl8712/rtl8712_led.c b/drivers/staging/rtl8712/rtl8712_led.c
> index c9eb4b7..6cb1a0a 100644
> --- a/drivers/staging/rtl8712/rtl8712_led.c
> +++ b/drivers/staging/rtl8712/rtl8712_led.c
> @@ -267,12 +267,8 @@ static void SwLedBlink(struct LED_871x *pLed)
>   				   LED_BLINK_SLOWLY_INTERVAL);
>   			break;
>   		case LED_BLINK_WPS:
> -			if (pLed->BlinkingLedState == LED_ON)
> -				_set_timer(&(pLed->BlinkTimer),
> -					   LED_BLINK_LONG_INTERVAL);
> -			else
> -				_set_timer(&(pLed->BlinkTimer),
> -					   LED_BLINK_LONG_INTERVAL);
> +			_set_timer(&(pLed->BlinkTimer),
> +					LED_BLINK_LONG_INTERVAL);
>   			break;
>   		default:
>   			_set_timer(&(pLed->BlinkTimer),
>




More information about the devel mailing list