[PATCH 2/2] staging: comedi: drivers: usbduxfast.c: fix for DMA buffers on stack

Dan Carpenter dan.carpenter at oracle.com
Sat Feb 23 17:34:42 UTC 2013


On Sat, Feb 23, 2013 at 04:59:43PM +0100, walter harms wrote:
> >> or is it possible to pass one byte
> >> in a register ? (aka char/int) without allocating ?
> > 
> > Nope, the USB host controllers must be able to DMA to this memory
> > location, so you have to allocate it dynamically, sorry.
> > 
> > thanks,
> 
> thx for clarification.
> 
> @Kumar Amit Mehta:
> Would you mind to add this as comment ? Allocating one byte does not
> look clever so maybe will come up with the idea of changing that.
> 

That can't happen.  The reason is already recorded in the git
history.  Greg and Ian know that DMA to stack memory doesn't work.
Most maintainers know about that.  If someone changed it back then
Fengguang would send an automatic email about it as soon as it was
committed to a public git tree.

regards,
dan carpenter



More information about the devel mailing list