[PATCH] staging/zcache fixed some checkpatch issues

Robert Berger git.rber at gmail.com
Fri Feb 15 10:53:00 UTC 2013


tmem.c:76: ERROR: "foo*bar" should be "foo *bar"
zcache-main.c:2057: WARNING: quoted string split across lines
zcache-main.c:2059: WARNING: Prefer pr_warn(... to pr_warning(...
zcache-main.c:2068: WARNING: quoted string split across lines
zcache-main.c:2070: WARNING: Prefer pr_warn(... to pr_warning(...

Signed-off-by: Robert Berger <rber.git at ReliableEmbeddedSystems.com>
---
 drivers/staging/zcache/tmem.c        |    2 +-
 drivers/staging/zcache/zcache-main.c |   10 ++++------
 2 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/zcache/tmem.c b/drivers/staging/zcache/tmem.c
index 56c8e60..7d3f3d9 100644
--- a/drivers/staging/zcache/tmem.c
+++ b/drivers/staging/zcache/tmem.c
@@ -73,7 +73,7 @@ void tmem_register_pamops(struct tmem_pamops *m)
  */
 
 static struct tmem_obj
-*__tmem_obj_find(struct tmem_hashbucket*hb, struct tmem_oid *oidp,
+*__tmem_obj_find(struct tmem_hashbucket *hb, struct tmem_oid *oidp,
 		 struct rb_node **parent, struct rb_node ***link)
 {
 	struct rb_node *_parent = NULL, **rbnode;
diff --git a/drivers/staging/zcache/zcache-main.c b/drivers/staging/zcache/zcache-main.c
index 52b43b7..0803ea3 100644
--- a/drivers/staging/zcache/zcache-main.c
+++ b/drivers/staging/zcache/zcache-main.c
@@ -2053,10 +2053,9 @@ static int __init zcache_init(void)
 		zbud_init();
 		register_shrinker(&zcache_shrinker);
 		old_ops = zcache_cleancache_register_ops();
-		pr_info("zcache: cleancache enabled using kernel "
-			"transcendent memory and compression buddies\n");
+		pr_info("zcache: cleancache enabled using kernel transcendent memory and compression buddies\n");
 		if (old_ops.init_fs != NULL)
-			pr_warning("zcache: cleancache_ops overridden");
+			pr_warn("zcache: cleancache_ops overridden");
 	}
 #endif
 #ifdef CONFIG_FRONTSWAP
@@ -2064,10 +2063,9 @@ static int __init zcache_init(void)
 		struct frontswap_ops old_ops;
 
 		old_ops = zcache_frontswap_register_ops();
-		pr_info("zcache: frontswap enabled using kernel "
-			"transcendent memory and zsmalloc\n");
+		pr_info("zcache: frontswap enabled using kernel transcendent memory and zsmalloc\n");
 		if (old_ops.init != NULL)
-			pr_warning("zcache: frontswap_ops overridden");
+			pr_warn("zcache: frontswap_ops overridden");
 	}
 #endif
 out:
-- 
1.7.9.5




More information about the devel mailing list