[PATCH 00/32] staging: comedi: vmk80xx: cleanup driver

H Hartley Sweeten hsweeten at visionengravers.com
Wed Feb 6 00:16:53 UTC 2013


Cleanup the probe/auto_attach and disconnect/detach code so that the
usb_driver (*probe) simply calls the comedi_driver (*auto_attach)
when the device is inserted and the (*disconnect) calls the (*detach)
when it is removed.

This allows removing the static array that held the private data used
by the driver as well as the static mutex that protected the array.

Put the boardinfo used by the driver into a const array instead of
having the probe create the boardinfo when the device is inserted.

Cleanup the subdevice init and remove some of the cruft.

H Hartley Sweeten (32):
  staging: comedi: vmk80xx: remove support for manual attaching
  staging: comedi: vmk80xx: move usb_driver (*disconnect) code
  staging: comedi: vmk80xx: use comedi_auto_unconfig() for (*disconnect)
  staging: comedi: vmk80xx: move boardinfo into a const array
  staging: comedi: vmk80xx: save the boardinfo in the comedi_device
  staging: comedi: vmk80xx: remove common and unused boardinfo
  staging: comedi: vmk80xx: remove VMK80XX_SUBD_* enum
  staging: comedi: vmk80xx: rename struct vmk80xx_usb
  staging: comedi: vmk80xx: consistently use the same local var names
  staging: comedi: vmk80xx: factor out usb endpoint detection
  staging: comedi: vmk80xx: factor out usb buffer allocation
  staging: comedi: vmk80xx: remove private data 'count'
  staging: comedi: vmk80xx: make sure private data is clean when detached
  staging: comedi: vmk80xx: remove private data 'probed'
  staging: comedi: vmk80xx: remove private data 'attached'
  staging: comedi: comedi_usb: allow comedi usb drivers to pass a 'context'
  staging: comedi: vmk80xx: push usb (*probe) into comedi (*auto_attach)
  staging: comedi: vmk80xx: remove need for boardinfo in private_data
  staging: comedi: vmk80xx: cleanup analog input subdevice init
  staging: comedi: vmk80xx: cleanup analog output subdevice init
  staging: comedi: vmk80xx: cleanup digital input subdevice init
  staging: comedi: vmk80xx: cleanup digital input subdevice init
  staging: comedi: vmk80xx: cleanup counter subdevice init
  staging: comedi: vmk80xx: cleanup pwm subdevice init
  staging: comedi: vmk80xx: remove digital output (*insn_read)
  staging: comedi: vmk80xx: remove digital output (*insn_write)
  staging: comedi: vmk80xx: remove digital input (*insn_read)
  staging: comedi: vmk80xx: remove unused #define
  staging: comedi: vmk80xx: remove CONFIG_COMEDI_DEBUG code
  staging: comedi: vmk80xx: cleanup the comedi_lrange tables
  staging: comedi: vmk80xx: remove the 'Changelog' comments
  staging: comedi: vmk80xx: rename vmk80xx_attach_common()

 drivers/staging/comedi/comedi_usb.c          |    6 +-
 drivers/staging/comedi/comedidev.h           |    3 +-
 drivers/staging/comedi/drivers/usbdux.c      |    2 +-
 drivers/staging/comedi/drivers/usbduxfast.c  |    2 +-
 drivers/staging/comedi/drivers/usbduxsigma.c |    2 +-
 drivers/staging/comedi/drivers/vmk80xx.c     | 1150 ++++++++++----------------
 6 files changed, 462 insertions(+), 703 deletions(-)

-- 
1.8.1.1.293.gfe73786




More information about the devel mailing list