[PATCH 01/10] staging/xgifb: Simplify XGI_GetRatePtrCRT2

Aaro Koskinen aaro.koskinen at iki.fi
Mon Feb 4 19:37:49 UTC 2013


Hi,

On Sun, Feb 03, 2013 at 10:54:30PM +0100, Peter Huewe wrote:
> Since the smaller LCDRefreshIndex is contained identically in LCDARefreshIndex
> we can simply use LCDARefreshIndex and skip the if/else.
> 
> Since LCDARefreshIndex is only used readonly and contains only small
> unsigned values we also change its declaration to const u8.
> 
> In order to prevent an out-of-bounds access I changed the mask from 0x0F
> to 0x07 and added a dummy value.
> 
> Signed-off-by: Peter Huewe <peterhuewe at gmx.de>
> ---
> Please apply this series after my previous one 
>  [PATCH 1/6] staging/xgifb: Remove unused variables and dead assignments
>  [PATCH 2/6] staging/xgifb: Remove unused variable
>  [PATCH 3/6] staging/xgifb: Remove unused variable and dead assignment
>  [PATCH 4/6] staging/xgifb: Remove unused variables
>  [PATCH 5/6] staging/xgifb: Remove redundant if statement
>  [PATCH 6/6] staging/xgifb: remove unused variables

I think both of these series are good. I boot tested them with Z9/XG21,
and at least fb console seems to work fine. I also checked compilation
for warnings with GCC+sparse and could not see any. So:

Tested-by: Aaro Koskinen <aaro.koskinen at iki.fi>

for all of the patches.

Thanks,

A.



More information about the devel mailing list