[PATCH 2/3] staging: dgnc: fix checkpatch.pl usage of volatile.

Dan Carpenter dan.carpenter at oracle.com
Sat Dec 21 09:07:35 UTC 2013


On Fri, Dec 20, 2013 at 10:03:26PM +0530, Stalin Srinivasan wrote:
> From: stalinsrinivasan.s <stalinsrinivasan.subramanian at in.bosch.com>
> 
> This is a patch to the dgnc_cls.c file that fixes up volatile usage
> warning found by the checkpatch.pl tool
> 

When you're writing a changelog please mention that you fixed the
locking a little.  We normally expect checkpatch.pl fixes will not
change how the program works.

"Checkpatch.pl complained about the use of 'volatile' here.  The locking
was a bit messed up and access to the 'ch' struct should be protected
using the 'ch->ch_lock' lock.  This patch adds proper locking and
removes the bogus 'volatile'."

regards,
dan carpenter



More information about the devel mailing list