[PATCH v2 2/4] staging: bcm: line over 80 characters in InterfaceIdleMode.c

Dan Carpenter dan.carpenter at oracle.com
Sat Dec 21 08:30:45 UTC 2013


On Fri, Dec 20, 2013 at 08:54:30PM +0530, Gokulnath A wrote:
> From: Gokulnath Avanashilingam <Gokulnath.Avanashilingam at in.bosch.com>

No need.  This should come from your email.

> 
> Fixed all the line over 80 characters warning found by
> checkpatch.pl script.
> 
> Signed-off-by: Gokulnath Avanashilingam <Gokulnath.Avanashilingam at in.bosch.com>

This doesn't match the email you are using so we can't verify it.

> -			if (Adapter->ulPowerSaveMode == DEVICE_POWERSAVE_MODE_AS_MANUAL_CLOCK_GATING) {
> +			if (Adapter->ulPowerSaveMode ==
> +				DEVICE_POWERSAVE_MODE_AS_MANUAL_CLOCK_GATING) {
>  				uiRegRead = 0x00000000 ;

The alignment here should be:

			if (Adapter->ulPowerSaveMode ==
			    DEVICE_POWERSAVE_MODE_AS_MANUAL_CLOCK_GATING) {
				uiRegRead = 0x00000000;

Notice how the 'A' and the 'D' are aligned?  I used space characters to
make that work.  Btw, hopefully this will fit on one line after we clean
up the variable names.

>  
> -		bytes = rdmalt(Adapter, DEVICE_INT_OUT_EP_REG1, &uiRegVal, sizeof(uiRegVal));
> +		bytes = rdmalt(Adapter,
> +			DEVICE_INT_OUT_EP_REG1,
> +			&uiRegVal, sizeof(uiRegVal));
>  		if (bytes < 0) {

The alignment here should be:

		bytes = rdmalt(Adapter, DEVICE_INT_OUT_EP_REG1, &uiRegVal,
			       sizeof(uiRegVal));
		if (bytes < 0) {

The 'A' and the 's' character are lined up.

regards,
dan carpenter


More information about the devel mailing list