[PATCH] staging: comedi: addi_apci_1032: fix subdevice type/flags bug

[Ian Abbott]

On 2013-12-09 23:06, H Hartley Sweeten wrote:
> The SDF_CMD_READ should be one of the s->subdev_flags not part of
> the s->type.
>
> Signed-off-by: H Hartley Sweeten <hsweeten at visionengravers.com>
> Cc: Ian Abbott <abbotti at mev.co.uk>
> Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
> ---
>   drivers/staging/comedi/drivers/addi_apci_1032.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/addi_apci_1032.c b/drivers/staging/comedi/drivers/addi_apci_1032.c
> index af2306c..0daa0ea 100644
> --- a/drivers/staging/comedi/drivers/addi_apci_1032.c
> +++ b/drivers/staging/comedi/drivers/addi_apci_1032.c
> @@ -325,8 +325,8 @@ static int apci1032_auto_attach(struct comedi_device *dev,
>   	s = &dev->subdevices[1];
>   	if (dev->irq) {
>   		dev->read_subdev = s;
> -		s->type		= COMEDI_SUBD_DI | SDF_CMD_READ;
> -		s->subdev_flags	= SDF_READABLE;
> +		s->type		= COMEDI_SUBD_DI;
> +		s->subdev_flags	= SDF_READABLE | SDF_CMD_READ;
>   		s->n_chan	= 1;
>   		s->maxdata	= 1;
>   		s->range_table	= &range_digital;
>

Reviewed-by: Ian Abbott <abbotti at mev.co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti at mev.co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-