[PATCH 4/7 RESEND] staging: et131x: reduce split lines in nic_return_rfd

Dan Carpenter dan.carpenter at oracle.com
Sat Dec 7 07:54:01 UTC 2013


On Sat, Dec 07, 2013 at 09:39:07AM +0800, ZHAO Gang wrote:
> Signed-off-by: ZHAO Gang <gamerh2o at gmail.com>
> ---
>  drivers/staging/et131x/et131x.c | 23 ++++++++++++-----------
>  1 file changed, 12 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
> index 881ae4f..90ef45b 100644
> --- a/drivers/staging/et131x/et131x.c
> +++ b/drivers/staging/et131x/et131x.c
> @@ -2495,16 +2495,19 @@ static void et131x_set_rx_dma_timer(struct et131x_adapter *adapter)
>   */
>  static void nic_return_rfd(struct et131x_adapter *adapter, struct rfd *rfd)
>  {
> +	unsigned long flags;
> +
>  	struct rx_ring *rx_local = &adapter->rx_ring;
>  	struct rxdma_regs __iomem *rx_dma = &adapter->regs->rxdma;
>  	u16 buff_index = rfd->bufferindex;
>  	u8 ring_index = rfd->ringindex;
> -	unsigned long flags;
> +	struct fbr_lookup *fbr = rx_local->fbr[ring_index];

No.  Don't do this.  Even though the declarations have initializers,
they all go together.

regards,
dan carpenter



More information about the devel mailing list