[PATCH 1/7 RESEND] staging: et131x: reduce split lines in et131x_config_rx_dma_regs

Dan Carpenter dan.carpenter at oracle.com
Sat Dec 7 06:49:56 UTC 2013


On Sat, Dec 07, 2013 at 09:19:04AM +0800, ZHAO Gang wrote:
> Signed-off-by: ZHAO Gang <gamerh2o at gmail.com>
> ---
>  drivers/staging/et131x/et131x.c | 25 +++++++++++--------------
>  1 file changed, 11 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
> index e3a71d3..0372f23 100644
> --- a/drivers/staging/et131x/et131x.c
> +++ b/drivers/staging/et131x/et131x.c
> @@ -1822,6 +1822,8 @@ static void et131x_config_rx_dma_regs(struct et131x_adapter *adapter)
>  		u32 __iomem *base_hi;
>  		u32 __iomem *base_lo;
>  
> +		struct fbr_lookup *fbr = rx_local->fbr[id];
> +

Gar no.  I'm sorry.  Please keep all the declarations in one block...

I was fine with the previous version honestly, sorry to make you redo
these over and over.

Don't put RESEND in the subject unless you are resending them unchanged
because the maintainers ignored them the first time.  Put a v2, or v3
there instead.

regards,
dan carpenter



More information about the devel mailing list