[PATCH] staging: silicom: fix 'return is not a function, parentheses are not required' in bpctl_mod.c
Joe Perches
joe at perches.com
Fri Dec 6 07:18:23 UTC 2013
On Fri, 2013-12-06 at 10:11 +0300, Dan Carpenter wrote:
> On Thu, Dec 05, 2013 at 03:29:22PM -0800, Joe Perches wrote:
> > On Fri, 2013-12-06 at 02:21 +0300, Dan Carpenter wrote:
> > > On Thu, Dec 05, 2013 at 03:09:15PM -0800, Joe Perches wrote:
> > > > On Fri, 2013-12-06 at 01:50 +0300, Dan Carpenter wrote:
> > > > > On Thu, Dec 05, 2013 at 10:23:53PM +0100, Will Tange wrote:
> >
> > Ah.
> >
> > Then maybe use a single ?: or a ! instead
> >
> > return ret ? 0 : 1;
> > or
> > return !ret;
> >
>
> You still have to handle the negative.
>
> if (ret < 0)
> return ret;
>
> return !ret;
Of course. Apologies for not being clear. I meant
using that ?: or ! after the first if (ret < 0) as
you wrote.
More information about the devel
mailing list