You and I generally agree on style preferences... I think the warning should be limited to grep " ;$". I did a grep on the kernel for ' ;' and found 8000 results. 6000 of them are caught by my semicolon before the newline rule. The remaining 2000 are assembly, macros, and crappy for loops. regards, dan carpenter