[PATCH v3 00/21] staging: comedi: tidy up digital output (*insn_bits)

H Hartley Sweeten hsweeten at visionengravers.com
Fri Aug 30 17:46:33 UTC 2013


Consolidate the boilerplate code used to mask and set the output channels of
DIO and DO subdevices.

v3: fix [PATCH 01/21] to prevent overflow when calculating s->io_bits
    fix [PATCH 02/21] so only the valid channels in the subdevice are modified
    drop the patch that only updated to output channels with comedi_dio_update_state()
    split the patch that modified the drivers that filtered the 'mask' by s->io_bits
    drop the change to the pcmuio driver
    
v2: address issues pointed out by Ian Abbott
    reorder series a bit
    pick up a couple drivers that were missed in v1
    
    The comedi_parport driver still needs converted. This driver will be
    converted and cleaned up in a separate series.

H Hartley Sweeten (21):
  staging: comedi: initialize subdevice s->io_bits in postconfig
  staging: comedi: drivers: introduce comedi_dio_update_state()
  staging: comedi: skel: use comedi_dio_update_state()
  staging: comedi: usbdux drivers: use comedi_dio_update_state()
  staging: comedi: drivers: use comedi_dio_update_state() for simple cases
  staging: comedi: drivers: use comedi_dio_update_state() for complex cases
  staging: comedi: ni_mio_common: use comedi_dio_update_state()
  staging: comedi: vmk80xx: use comedi_dio_update_state()
  staging: comedi: das08: remove do_bits from private data
  staging: comedi: das08: use s->state in das08_do_wbits()
  staging: comedi: das1800: remove do_bits from private data
  staging: comedi: das16m1: remove do_bits from private data
  staging: comedi: adq12b: remove digital_state from private data
  staging: comedi: ssv_dnp: use comedi_dio_update_state()
  staging: comedi: hwdrv_apci3120: use comedi_dio_update_state()
  staging: comedi: addi_apci_16xx: use comedi_dio_update_state()
  staging: comedi: addi_apci_3xxx: use comedi_dio_update_state()
  staging: comedi: ii_pci20kc: use comedi_dio_update_state()
  staging: comedi: me4000: use comedi_dio_update_state()
  staging: comedi: me_daq: use comedi_dio_update_state()
  staging: comedi: s626: use comedi_dio_update_state()

 drivers/staging/comedi/comedidev.h                 |  2 +
 drivers/staging/comedi/drivers.c                   | 29 +++++++++
 drivers/staging/comedi/drivers/8255.c              | 25 +++-----
 .../staging/comedi/drivers/addi-data/addi_common.c |  2 -
 .../comedi/drivers/addi-data/hwdrv_apci1564.c      |  7 +--
 .../comedi/drivers/addi-data/hwdrv_apci3120.c      | 17 ++----
 .../comedi/drivers/addi-data/hwdrv_apci3200.c      |  7 +--
 drivers/staging/comedi/drivers/addi_apci_1516.c    |  8 +--
 drivers/staging/comedi/drivers/addi_apci_16xx.c    | 11 +---
 drivers/staging/comedi/drivers/addi_apci_2032.c    |  8 +--
 drivers/staging/comedi/drivers/addi_apci_2200.c    |  8 +--
 drivers/staging/comedi/drivers/addi_apci_3120.c    |  2 -
 drivers/staging/comedi/drivers/addi_apci_3501.c    |  8 +--
 drivers/staging/comedi/drivers/addi_apci_3xxx.c    | 17 +-----
 drivers/staging/comedi/drivers/adl_pci6208.c       | 10 +---
 drivers/staging/comedi/drivers/adl_pci7x3x.c       | 13 +---
 drivers/staging/comedi/drivers/adl_pci9111.c       |  9 +--
 drivers/staging/comedi/drivers/adl_pci9118.c       | 11 ++--
 drivers/staging/comedi/drivers/adq12b.c            | 32 +++++-----
 drivers/staging/comedi/drivers/adv_pci1710.c       | 16 ++---
 drivers/staging/comedi/drivers/adv_pci1723.c       | 13 ++--
 drivers/staging/comedi/drivers/adv_pci_dio.c       | 33 ++++------
 drivers/staging/comedi/drivers/aio_iiro_16.c       |  4 +-
 .../staging/comedi/drivers/amplc_dio200_common.c   | 33 +++++-----
 drivers/staging/comedi/drivers/amplc_pc263.c       | 17 +++---
 drivers/staging/comedi/drivers/amplc_pci263.c      | 17 +++---
 drivers/staging/comedi/drivers/cb_das16_cs.c       |  9 +--
 drivers/staging/comedi/drivers/cb_pcidas64.c       | 25 ++++----
 drivers/staging/comedi/drivers/contec_pci_dio.c    | 12 +---
 drivers/staging/comedi/drivers/das08.c             | 46 ++++++--------
 drivers/staging/comedi/drivers/das08.h             |  1 -
 drivers/staging/comedi/drivers/das16.c             |  9 +--
 drivers/staging/comedi/drivers/das16m1.c           | 22 ++-----
 drivers/staging/comedi/drivers/das1800.c           | 22 ++-----
 drivers/staging/comedi/drivers/das800.c            |  6 +-
 drivers/staging/comedi/drivers/dmm32at.c           | 70 +++++++++-------------
 drivers/staging/comedi/drivers/dt2801.c            | 18 +++---
 drivers/staging/comedi/drivers/dt2811.c            |  8 +--
 drivers/staging/comedi/drivers/dt2817.c            | 51 +++++++---------
 drivers/staging/comedi/drivers/dt282x.c            | 10 ++--
 drivers/staging/comedi/drivers/dt3000.c            |  9 ++-
 drivers/staging/comedi/drivers/dt9812.c            |  9 +--
 drivers/staging/comedi/drivers/dyna_pci10xx.c      | 20 ++-----
 drivers/staging/comedi/drivers/icp_multi.c         | 14 +----
 drivers/staging/comedi/drivers/ii_pci20kc.c        |  7 +--
 drivers/staging/comedi/drivers/me4000.c            | 25 +-------
 drivers/staging/comedi/drivers/me_daq.c            |  9 +--
 drivers/staging/comedi/drivers/multiq3.c           |  8 +--
 drivers/staging/comedi/drivers/ni_6527.c           | 22 +++----
 drivers/staging/comedi/drivers/ni_660x.c           |  1 -
 drivers/staging/comedi/drivers/ni_670x.c           | 11 +---
 drivers/staging/comedi/drivers/ni_at_ao.c          |  8 +--
 drivers/staging/comedi/drivers/ni_atmio16d.c       |  9 ++-
 drivers/staging/comedi/drivers/ni_daq_700.c        | 19 +++---
 drivers/staging/comedi/drivers/ni_mio_common.c     | 45 +++++---------
 drivers/staging/comedi/drivers/ni_pcidio.c         |  9 ++-
 drivers/staging/comedi/drivers/pcl711.c            | 19 +++---
 drivers/staging/comedi/drivers/pcl726.c            | 19 +++---
 drivers/staging/comedi/drivers/pcl730.c            | 13 ++--
 drivers/staging/comedi/drivers/pcl812.c            | 11 ++--
 drivers/staging/comedi/drivers/pcl818.c            | 18 ++----
 drivers/staging/comedi/drivers/quatech_daqp_cs.c   |  8 +--
 drivers/staging/comedi/drivers/rtd520.c            |  8 +--
 drivers/staging/comedi/drivers/rti800.c            |  8 +--
 drivers/staging/comedi/drivers/s526.c              |  9 +--
 drivers/staging/comedi/drivers/s626.c              | 13 +---
 drivers/staging/comedi/drivers/skel.c              | 46 +++++++++-----
 drivers/staging/comedi/drivers/ssv_dnp.c           | 48 +++++++--------
 drivers/staging/comedi/drivers/usbdux.c            |  6 +-
 drivers/staging/comedi/drivers/usbduxsigma.c       |  6 +-
 drivers/staging/comedi/drivers/vmk80xx.c           | 35 ++++-------
 71 files changed, 438 insertions(+), 722 deletions(-)

-- 
1.8.3.2



More information about the devel mailing list