[PATCH 00/15] staging: comedi: comedi_parport: cleanup driver

[Ian Abbott]

On 2013-08-30 01:59, Hartley Sweeten wrote:
> On Thursday, August 29, 2013 7:19 AM, Ian Abbott wrote:
>> On 2013-08-28 21:55, H Hartley Sweeten wrote:
>>> Use the new comedi_dio_insn_bits() and comedi_dio_insn_config() helpers
>>> to tidy up the digital subdevices in this driver.
>>>
>>> Remove the need for the kzalloc'd private data.
>>>
>>> H Hartley Sweeten (15):
>>>     staging: comedi: comedi_parport: tidy up the register map
>>>     staging: comedi: comedi_parport: remove 'a_data' from private data
>>>     staging: comedi: comedi_parport: tidy up parport_insn_a()
>>>     staging: comedi: comedi_parport: fix parport_insn_config_a()
>>>     staging: comedi: comedi_parport: tidy up parport_insn_b()
>>>     staging: comedi: comedi_parport: tidy up parport_insn_c()
>>>     staging: comedi: comedi_parport: remove 'c_data' from private data
>>>     staging: comedi: comedi_parport: remove 'enable_irq' from private data
>>>     staging: comedi: comedi_parport: don't fail attach if irq is not available
>>>     staging: comedi: comedi_parport: tidy up parport_attach()
>>>     staging: comedi: comedi_parport: tidy up multi-line comments
>>>     staging: comedi: comedi_parport: reorder #include's
>>>     staging: comedi: comedi_parport: rename parport_intr_insn()
>>>     staging: comedi: comedi_parport: use dev->read_subdev in interrupt handler
>>>     staging: comedi: comedi_parport: change MODULE_DESCRIPTION
>>>
>>>    drivers/staging/comedi/drivers/comedi_parport.c | 380 +++++++++++-------------
>>>    1 file changed, 177 insertions(+), 203 deletions(-)
>>
>> Reviewed-by: Ian Abbott <abbotti at mev.co.uk>
>>
>> Looks okay, but it depends on the "staging: comedi: tidy up digital
>> Output (*insn_bits)" patch series that I had a few issues with.
>
> Greg,
>
> Please drop this series. I need to rebase in due to the v2 changes to the
> "staging: comedi: tidy up digital output (*insn_bits)" series.
>
> Ian,
>
> The rebase is due to the change of comedi_dio_insn_bits() to
> comedi_dio_update_state(). Do you want me to still add your
> Reviewed-by tag?

Yes, that should be fine as long as only bits 0 to 3 of PARPORT_CTRL_REG 
get modified by parport_ctrl_reg_insn_bits().

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti at mev.co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-