[PATCH] staging: dgnc: adds TODO
Lidza Louina
lidza.louina at gmail.com
Thu Aug 29 23:00:37 UTC 2013
This patchs adds a TODO for the driver.
Signed-off-by: Lidza Louina <lidza.louina at gmail.com>
---
drivers/staging/dgnc/TODO | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
create mode 100644 drivers/staging/dgnc/TODO
diff --git a/drivers/staging/dgnc/TODO b/drivers/staging/dgnc/TODO
new file mode 100644
index 0000000..1ff2d18
--- /dev/null
+++ b/drivers/staging/dgnc/TODO
@@ -0,0 +1,17 @@
+* remove kzalloc casts
+* checkpatch fixes
+* sparse fixes
+* fix use of sizeof(). Example replace sizeof(struct board_t)
+ with sizeof(*brd) and remove sizeof(char)
+* change name of board_t to dgnc_board
+* split two assignments into the two assignments on two lines;
+ don't use two equals signs
+* remove unecessary comments
+* remove unecessary error messages. Example kzalloc() has its
+ own error message. Adding an extra one is useless.
+* use goto statements for error handling when appropriate
+* there is a lot of unecessary code in the driver. It was
+ originally a standalone driver. Remove uneeded code.
+
+Please send patches to Greg Kroah-Hartman <greg at kroah.com> and
+Cc: Lidza Louina <lidza.louina at gmail.com>
--
1.8.1.2
More information about the devel
mailing list