[PATCH Resend 1/4] staging: dgap: Include version.h header in dgap_kcompat.h

Sachin Kamat sachin.kamat at linaro.org
Thu Aug 29 05:43:56 UTC 2013


On 29 August 2013 03:45, Greg KH <gregkh at linuxfoundation.org> wrote:
> On Wed, Aug 28, 2013 at 10:35:46AM +0530, Sachin Kamat wrote:
>> Include version.h header file as detected by versioncheck.
>>
>> Cc: Lidza Louina <lidza.louina at gmail.com>
>> Signed-off-by: Sachin Kamat <sachin.kamat at linaro.org>
>> ---
>>  drivers/staging/dgap/dgap_kcompat.h |    2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/staging/dgap/dgap_kcompat.h b/drivers/staging/dgap/dgap_kcompat.h
>> index 8ebf4b7..f21c8d7 100644
>> --- a/drivers/staging/dgap/dgap_kcompat.h
>> +++ b/drivers/staging/dgap/dgap_kcompat.h
>> @@ -28,6 +28,8 @@
>>  #ifndef __DGAP_KCOMPAT_H
>>  #define __DGAP_KCOMPAT_H
>>
>> +#include <linux/version.h>
>
> Please just remove the KERNEL_VERSION check, and the use of the macro in
> this file entirely, as it's pointless here.

Agreed. That was my initial thought too.
Will update and re-spin.


-- 
With warm regards,
Sachin


More information about the devel mailing list