[PATCH] LMK: Optimize lowmem_shrink

Sergey Senozhatsky sergey.senozhatsky at gmail.com
Fri Aug 23 21:20:21 UTC 2013


On (08/23/13 09:48), Greg KH wrote:
> Subject: Re: [PATCH] LMK: Optimize lowmem_shrink
> User-Agent: Mutt/1.5.21 (2010-09-15)
> 
> On Wed, Aug 21, 2013 at 09:41:05AM +0800, Leon Ma wrote:
> > From: Leon Ma <xindong.ma at intel.com>
> > Date: Mon, 19 Aug 2013 14:22:38 +0800
> > Subject: [PATCH] LMK: Optimize lowmem_shrink.
> 
> Why is all of this in the patch body?
> 
> And what does "LMK:" stand for?
>
> > By comparing with selected_oom_score_adj instead of min_score_adj,
> > we may do less calculation.
> 
> What does this change?  Does it fix a problem?

Hello,

linux-next since

	c95dd63d4cc3647643ff502d70c4c1b52947c770
	Author: Dave Chinner <dchinner at redhat.com>
	Date:   Fri Aug 16 09:39:54 2013 +1000

	drivers: convert shrinkers to new count/scan API

does not contain lowmem_shrink(), but lowmem_scan() instead. plus at lest
one more patch on top of it (e2bfaf75e763396b7baa7c1effa4053d7f19e6d3):

[..]
-static int lowmem_shrink(struct shrinker *s, struct shrink_control *sc)

+static long lowmem_scan(struct shrinker *s, struct shrink_control *sc)
[..]

wouldn't it be better to have the patch against -next in this case (in
case it fixes anything)?

thanks,
	-ss

> thanks,
> 
> greg k-h
> _______________________________________________
> devel mailing list
> devel at linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
> 


More information about the devel mailing list