[PATCH -next] staging: lustre: Use proper constant types for L*_POISON values

Greg Kroah-Hartman gregkh at linuxfoundation.org
Fri Aug 23 17:21:02 UTC 2013


On Fri, Aug 23, 2013 at 05:46:48PM +0200, Geert Uytterhoeven wrote:
> On 32-bit m68k, I get lots of warnings like:
> 
>     warning: integer constant is too large for ‘long’ type
> 
> Switch the L*_POISON definitions from too-large constants and casts
> to the proper constant types to fix this.
> 
> Signed-off-by: Geert Uytterhoeven <geert at linux-m68k.org>
> ---
> The values in drivers/staging/lustre/lustre/include/linux/lustre_lib.h
> don't seem to be used, as LP_POISON is already defined at that point?

Probably.  I don't see where anyone even uses these "poison" values,
except to check variables to ensure they don't contain the value, which
is always going to be true as no one sets them.

Oh well, more dead code in the driver, nothing new...

thanks,

greg k-h


More information about the devel mailing list