[PATCH] staging: dgnc: tty.c: fixes pointer syntax

Dan Carpenter dan.carpenter at oracle.com
Fri Aug 23 08:40:19 UTC 2013

On Wed, Aug 21, 2013 at 01:27:15PM -0400, Lidza Louina wrote:
> This patch fixes the error: "foo* bar" should be "foo *bar".

I have a nit pick about this changelog.  It's not something to
resend over, of course, but for future patches.  The word "fix"
should only be used for bugfixes.  The word "clean up" is the
opposite and should not be used for changes which affect how the
code works.

It's pretty much kernel standard to separate fixes and cleanups as
two different things.

A "syntax error" means something that breaks the compile.  So I was
expecting a fix for the compile.  A better subject would be:
"[PATCH] staging: dgnc: tty.c: clean up pointer white space"

dan carpenter

More information about the devel mailing list