[PATCH] staging: dgap: adds driver to kernel build

Greg KH gregkh at linuxfoundation.org
Thu Aug 22 17:52:41 UTC 2013


On Thu, Aug 22, 2013 at 01:40:35PM -0400, Lidza Louina wrote:
> This patch adds the dgap driver to the kernel build process.
> 
> Signed-off-by: Lidza Louina <lidza.louina at gmail.com>

I've applied this, but I'm getting this build warning now:

drivers/staging/dgap/dgap_mgmt.c: In function ‘dgap_mgmt_ioctl’:
drivers/staging/dgap/dgap_mgmt.c:403:5: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
drivers/staging/dgap/dgap_mgmt.c:439:5: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
drivers/staging/dgap/dgap_mgmt.c:458:5: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]

That whole file can be deleted, along with the "management" and
"firmware download" character devices, and class devices, they should
not be needed at all.  If they are needed, they can come back later,
using the proper way to configure devices (configfs) and handle firmware
(the firmware core).

For now, I'd recommend deleting it all.

Oh, also delete the proc .c files, they aren't being built, so feel free
to just remove them.  If anyone ever needs them back, they are in the
git history so they can be found there.

thanks,

greg k-h


More information about the devel mailing list