[PATCH] staging: dgnc: mgmt.c: removes unused variable

Dan Carpenter dan.carpenter at oracle.com
Tue Aug 20 08:48:53 UTC 2013


On Tue, Aug 20, 2013 at 12:19:38AM -0400, Lidza Louina wrote:
> This patch removes the inode variable from the
> dgnc_mgmt_ioctl function. It's never used in the
> function.
> 
> Signed-off-by: Lidza Louina <lidza.louina at gmail.com>
> ---
>  drivers/staging/dgnc/dgnc_mgmt.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/dgnc/dgnc_mgmt.c b/drivers/staging/dgnc/dgnc_mgmt.c
> index bbd65db..7958977 100644
> --- a/drivers/staging/dgnc/dgnc_mgmt.c
> +++ b/drivers/staging/dgnc/dgnc_mgmt.c
> @@ -128,7 +128,6 @@ int dgnc_mgmt_close(struct inode *inode, struct file *file)
>  #ifdef HAVE_UNLOCKED_IOCTL
>  long dgnc_mgmt_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
>  {
> -	struct inode *inode = file->f_dentry->d_inode;
>  #else        
>  int dgnc_mgmt_ioctl(struct inode *inode, struct file *file, unsigned int cmd, unsigned long arg)
>  {

The ifdef here is to support older kernels which don't have the
the ->unlocked_ioctl function pointer.  We don't care about older
kernels so we could delete the #else side of this and remove the
#ifdef.

You can do that in a later patch if you want.

regards,
dan carpenter



More information about the devel mailing list