[PATCH 2/3] Staging: olpc_dcon: replace some magic numbers
Jens Frederich
jfrederich at gmail.com
Fri Aug 16 07:40:38 UTC 2013
On Fri, Aug 16, 2013 at 9:13 AM, Dan Carpenter <dan.carpenter at oracle.com> wrote:
> On Thu, Aug 15, 2013 at 09:34:55PM +0200, Jens Frederich wrote:
>> The 0x42 initialize squence 0x101 is wrong. According to
>> the specification Bit 8 is reserved, thus not in use.
>> I removed it.
>
> Really these code changes should be in a separate patch and labeled
> "Don't set reserved bit." instead of hidden away inside a cleanup
> patch.
>
The patch is applied. Still, good to know. It's not so easy to find the
right patch granularity as newbie.
Greg, what's your opinion, should I split the patch up?
thanks,
jens
More information about the devel
mailing list