[PATCH v2 0/4] staging: comedi: tidy up dio subdevice (*insn_config) boilerplate

Greg Kroah-Hartman gregkh at linuxfoundation.org
Wed Aug 14 18:39:08 UTC 2013


On Wed, Aug 14, 2013 at 01:19:23PM -0500, H Hartley Sweeten wrote:
> On Monday, August 12, 2013 3:18 PM, Greg Kroah-Hartman wrote:
> > On Tue, Aug 06, 2013 at 09:30:33AM -0700, H Hartley Sweeten wrote:
> >> All the comedi drivers that have DIO subdevices implement a (*insn_config)
> >> callback. This callback always handles the INSN_CONFIG_DIO_{INPUT,OUTPUT}
> >> instructions to configure the DIO channels. They also always handle the
> >> INSN_CONFIG_DIO_QUERY instruction to query the configuration of a DIO channel.
> >> 
> >> Introduce, and use, a new exported function in the comedi core to handle this
> >> boilerplate.
> >> 
> >> v2: Patches 1, 2, and 4: Add Reviewed-by signoff from Ian Abbott.
> >>     Patch 3: Drop changes to comedi_bond and ni_65xx drivers as suggested by Ian.
> >>              Add comment back in ssv_dnp driver about the mysterious multiplication
> >>              by 2 for port C.
> >
> > Ok, I think I got this all applied properly, it took me a few tries as
> > your inbox will show :)
> >
> > If I've messed anything up, or missed anything, please resend it,
> > thanks.
> 
> Sorry I didn't get back to you sooner on this. My daughter was born
> yesterday. :-)

No worries, congratulations!

> The order is a bit messed up but the patches all look correct.
> 
> This should not cause any regression issues so the order is probably not
> a problem.

Great, thanks for looking and letting us know.  Go get some rest now,
you will need it :)

greg k-h


More information about the devel mailing list