[PATCH 03/10] staging: ozwpan: Simply if condition

Rupesh Gujare rupesh.gujare at atmel.com
Tue Aug 13 17:24:23 UTC 2013


Making code simpler for readability.

Reported-by: Dan Carpenter <dan.carpenter at oracle.com>
Signed-off-by: Rupesh Gujare <rupesh.gujare at atmel.com>
---
 drivers/staging/ozwpan/ozhcd.c |    9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan/ozhcd.c
index 5a417c8..4b658d4 100644
--- a/drivers/staging/ozwpan/ozhcd.c
+++ b/drivers/staging/ozwpan/ozhcd.c
@@ -478,7 +478,7 @@ static int oz_enqueue_ep_urb(struct oz_port *port, u8 ep_addr, int in_dir,
 			struct urb *urb, u8 req_id)
 {
 	struct oz_urb_link *urbl;
-	struct oz_endpoint *ep;
+	struct oz_endpoint *ep = NULL;
 	int err = 0;
 
 	if (ep_addr >= OZ_NB_ENDPOINTS) {
@@ -506,11 +506,12 @@ static int oz_enqueue_ep_urb(struct oz_port *port, u8 ep_addr, int in_dir,
 		oz_free_urb_link(urbl);
 		return 0;
 	}
-	if (in_dir && port->in_ep[ep_addr])
+
+	if (in_dir)
 		ep = port->in_ep[ep_addr];
-	else if (!in_dir && port->out_ep[ep_addr])
+	else
 		ep = port->out_ep[ep_addr];
-	else {
+	if (!ep) {
 		err = -ENOMEM;
 		goto out;
 	}
-- 
1.7.9.5



More information about the devel mailing list