[PATCH 2/4] staging: ozwpan: Increment port number for new device.

Greg KH gregkh at linuxfoundation.org
Mon Aug 12 21:57:56 UTC 2013


On Mon, Aug 05, 2013 at 06:40:13PM +0100, Rupesh Gujare wrote:
> This patch fixes crash issue when there is quick cycle of
> de-enumeration & enumeration due to loss of wireless link.
> 
> It is found that sometimes new device (or coming back device)
> returns very fast, even before USB core read out hub status,
> resulting in allocation of same port, which results in unstable
> system & crash.
> 
> Above issue is resolved by making sure that we always assign
> new port to new device, making sure that USB core reads correct
> hub status.
> 
> Signed-off-by: Rupesh Gujare <rupesh.gujare at atmel.com>
> ---
>  drivers/staging/ozwpan/ozhcd.c |   16 +++++++++++-----
>  1 file changed, 11 insertions(+), 5 deletions(-)

No, don't paper over this, fix it correctly with reference counting as
Dan has suggested.

thanks,

greg k-h


More information about the devel mailing list