[PATCH 0/5] staging: comedi: ni_labpc: split out PCI support

H Hartley Sweeten hartleys at visionengravers.com
Tue Apr 23 16:52:25 UTC 2013


On Tuesday, April 23, 2013 9:29 AM, H Hartley Sweeten wrote:
> On April 23, 2013 4:32 AM , Ian Abbott wrote:

<snip>

>> Though I'm wondering whether or not AI command support on the ISA card 
>> when no DMA channel is specified works the same as on PCMCIA.
>
> My guess is that the AI command support works fine with just
> Interrupts. But, the maximum acquisition rate would be lower.
>
> For simplicity, and since this is a legacy driver, it might be worth just
> stripping out the DMA support completely. It would make splitting
> the ISA support out easier.

FYI, removing all the ISA DMA support in this driver results in a
diffstat of:

 drivers/staging/comedi/drivers/ni_labpc.c | 207 ++--------------------------------------------------------
 drivers/staging/comedi/drivers/ni_labpc.h |   4 +-
 2 files changed, 5 insertions(+), 206 deletions(-)

It also remove the dependency on VIRT_TO_BUS which is
deprecated.

Regards,
Hartley




More information about the devel mailing list