[PATCH 01/12] staging: comedi: drivers: introduce comedi_legacy_detach()

Ian Abbott abbotti at mev.co.uk
Thu Apr 18 10:50:05 UTC 2013


On 2013-04-18 11:48, Ian Abbott wrote:
> On 2013-04-18 11:36, Ian Abbott wrote:
>
>> An alternative implementation would be to leave
>> __comedi_request_region() alone, but change comedi_request_region() to
>> record the length in a new member dev->iolen at the same time that it
>> records the start address in dev->iobase.  Then your
>> comedi_legacy_detach() could do something like:
>>
>> 	if (dev->iolen) {
>> 		release_region(dev->iobase, dev->iolen);
>> 		dev->iolen = 0;
>> 	}
>>
>> I think it seems slightly simpler and shouldn't affect your other
>> patches.  Any thoughts?
>
> Well it would conflict with your existing patch 10 slightly, but
> shouldn't affect the drivers.

Sorry, I mean it would conflict with your existing patch 11.  (Must 
engage brain before hitting 'Send'....)

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti at mev.co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-



More information about the devel mailing list