[PATCH 08/12] staging: comedi: amplc_dio200: use comedi_legacy_detach()

H Hartley Sweeten hsweeten at visionengravers.com
Wed Apr 17 18:19:27 UTC 2013

The I/O region used by this driver is always requested using
comedi_request_region(). The devpriv->io union is only used by
the common code shared by the legacy and PCI drivers.

Use the new comedi_legacy_detach() helper in the (*detach) to
release the I/O region requested by this driver. That function
will handle the proper sanity checking before releasing the

Signed-off-by: H Hartley Sweeten <hsweeten at visionengravers.com>
Cc: Ian Abbott <abbotti at mev.co.uk>
Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
 drivers/staging/comedi/drivers/amplc_dio200.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/drivers/staging/comedi/drivers/amplc_dio200.c b/drivers/staging/comedi/drivers/amplc_dio200.c
index dc35cc9..297750b 100644
--- a/drivers/staging/comedi/drivers/amplc_dio200.c
+++ b/drivers/staging/comedi/drivers/amplc_dio200.c
@@ -292,14 +292,8 @@ static int dio200_attach(struct comedi_device *dev, struct comedi_devconfig *it)
 static void dio200_detach(struct comedi_device *dev)
-	const struct dio200_board *thisboard = comedi_board(dev);
-	struct dio200_private *devpriv = dev->private;
-	if (!thisboard || !devpriv)
-		return;
-	if (devpriv->io.regtype == io_regtype)
-		release_region(devpriv->io.u.iobase, thisboard->mainsize);
+	comedi_legacy_detach(dev);
 static struct comedi_driver amplc_dio200_driver = {

More information about the devel mailing list