[PATCH] staging: comedi: 8255_pci: check BAR resource type directly

H Hartley Sweeten hartleys at visionengravers.com
Fri Apr 12 17:15:19 UTC 2013

On Friday, April 12, 2013 5:58 AM, Ian Abbott wrote:
> This driver handles one or more 8255 DIO subdevices mapped contiguously
> at the start of a PCI BAR resource.  The resource may be a portio
> resource or an mmio resource.  The driver currently checks the `is_mmio`
> member of the matching element of `pci_8255_boards[]` to determine the
> type of resource.  Rather than doing that, get the information straight
> from the horse's mouth by checking the resource flags of the PCI BAR
> and eliminate the `is_mmio` member.
> Signed-off-by: Ian Abbott <abbotti at mev.co.uk>
> ---
>  drivers/staging/comedi/drivers/8255_pci.c | 15 +++++----------
>  1 file changed, 5 insertions(+), 10 deletions(-)

Well, I wrote this one so whichever is appropriate:

Acked-by: H Hartley Sweeten <hsweeten at visionengravers.com>
Reviewed-by: H Hartley Sweeten <hsweeten at visionengravers.com>


More information about the devel mailing list