[PATCH 01/79] staging: comedi: drivers: introduce comedi_request_region()

Ian Abbott abbotti at mev.co.uk
Wed Apr 10 08:55:36 UTC 2013


On 2013-04-10 09:48, Ian Abbott wrote:
> On 2013-04-10 00:05, H Hartley Sweeten wrote:
>> Introduce a helper function to handle the request_region() for legacy
>> comedi drivers.
>>
>> As pointed out by Ian Abbott, legacy devices are configured manually
>> with the "comedi_config" program. The error messages are useful
>> diagnostics when trying to attach to these boards.
>>
>> Providing a helper function allows consolidating the error messages
>> in the drivers and providing a consistent format for the errors.
>>
>> This helper also sets the dev->iobase automatically for the driver
>> if the request_region() is successful.
>
> I wouldn't have set dev->iobase automatically, just in case some driver
> wants to request two regions, for example das16.c (and pcl818.c before
> you removed the unused DMA code).

... but I suppose your __comedi_request_region() takes care of that problem!

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti at mev.co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-



More information about the devel mailing list