[PATCH v3 1/2] staging: speakup: reuse native hex2bin()

Samuel Thibault samuel.thibault at ens-lyon.org
Tue Apr 9 15:38:10 UTC 2013


Andy Shevchenko, le Tue 09 Apr 2013 15:22:15 +0300, a écrit :
> @@ -349,21 +349,8 @@ char *spk_xlate(char *s)
>  				num = (*p1++)&7;
>  			}
>  			*p++ = num;
> -		} else if (*p1 == 'x' &&
> -				strchr(hx, p1[1]) && strchr(hx, p1[2])) {
...
> +		} else if (*p1 == 'x' && !hex2bin(&num, p1 + 1, 1)) {
> +			p1 += 3;

Checking it again, I realize that this does not check p1[1]!=0 and
p1[2]!=0 any more ; it has to because hex2bin does not perform the
check (and could thus erroneously dereference p1[2]).

Samuel



More information about the devel mailing list