[PATCH 1/3] staging: speakup: reuse native kernel functions

Andy Shevchenko andriy.shevchenko at linux.intel.com
Tue Apr 9 12:06:06 UTC 2013


On Mon, 2013-04-01 at 12:18 +0300, Dan Carpenter wrote: 
> On Wed, Mar 27, 2013 at 05:44:55PM +0200, Andy Shevchenko wrote:
> > We have simple_strtoul and simple_strtol. Don't repeat their functionality
> > here.
> > 
> 
> Run your patches through checkpatch.pl.  It will tell you do use
> kstrtoul() instead of simple_strtoul().

Unfortunately kstrto* have limitation - it works only on null-terminated
"number" strings, which is not a case here and in many other places in
kernel where input is more complicated than just a plain number in ascii
form.

-- 
Andy Shevchenko <andriy.shevchenko at linux.intel.com>
Intel Finland Oy



More information about the devel mailing list