[PATCH 18/28] staging: comedi: rti800: tidy up rti800_ao_insn_read()

H Hartley Sweeten hsweeten at visionengravers.com
Tue Apr 9 01:19:23 UTC 2013

For aesthetic reasons, tidy up the parameters passed to this function.

The comedi core expects (*insn_read) functions to return the number
of data values actually read (insn->n). Change the return to make

Signed-off-by: H Hartley Sweeten <hsweeten at visionengravers.com>
Cc: Ian Abbott <abbotti at mev.co.uk>
Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
 drivers/staging/comedi/drivers/rti800.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/comedi/drivers/rti800.c b/drivers/staging/comedi/drivers/rti800.c
index 226c0d5..04ba9e6 100644
--- a/drivers/staging/comedi/drivers/rti800.c
+++ b/drivers/staging/comedi/drivers/rti800.c
@@ -219,16 +219,17 @@ static int rti800_ai_insn_read(struct comedi_device *dev,
 static int rti800_ao_insn_read(struct comedi_device *dev,
 			       struct comedi_subdevice *s,
-			       struct comedi_insn *insn, unsigned int *data)
+			       struct comedi_insn *insn,
+			       unsigned int *data)
 	struct rti800_private *devpriv = dev->private;
-	int i;
 	int chan = CR_CHAN(insn->chanspec);
+	int i;
 	for (i = 0; i < insn->n; i++)
 		data[i] = devpriv->ao_readback[chan];
-	return i;
+	return insn->n;
 static int rti800_ao_insn_write(struct comedi_device *dev,

More information about the devel mailing list