[PATCH 0/5] staging: comedi: initialize dev->board_name in the core

H Hartley Sweeten hartleys at visionengravers.com
Mon Apr 8 18:38:58 UTC 2013

On Monday, April 08, 2013 11:19 AM, Ian Abbott wrote:
> On 2013-04-08 18:54, H Hartley Sweeten wrote:
>> Initialize the dev->board_name in the comedi core before calling the (*attach)
>> or (*auto_attach) function.
>> Remove all the iitialization of the dev->board_name in the comedi drivers.
>> H Hartley Sweeten (5):
>>    staging: comedi: drivers: rename 'comedi_dev' in comedi_auto_config()
>>    staging: comedi: drivers: set dev->board_name before attaching
>>    staging: comedi: drivers: dev->board_name is always valid
>>    staging: comedi: comedi_pci: dev->board_name is always valid
>>    staging: comedi: remove unnecessary dev->board_name initialization
> They all look fine to me.
> Reviewed-by: Ian Abbott <abbotti at mev.co.uk>


There are a couple more drivers that still need the dev->board_name
init removed. They are all legacy drivers that have use the board_ptr. 
I'm still looking at them to make sure they don't do any additional probing.

I'll post those after this series is accepted.

> (P.S. Hartley, I don't know if you plan to resubmit those other changes 
> you had that passed a "main" PCI BAR index to comedi_pci_enable(), but I 
> don't think they're as useful now as they were when you initially 
> submitted them, so I wouldn't bother if I were you.)

No. Now that you added the 'ioenabled' flag it makes more sense to
leave the iobase initialization in the driver.


-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti at mev.co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-

More information about the devel mailing list