[PATCH 00/14] staging: comedi: serial2002: cleanup driver

H Hartley Sweeten hsweeten at visionengravers.com
Fri Apr 5 23:07:16 UTC 2013


Fix the sparse and checkpatch.pl warnings in this driver.

Cleanup the code and remove the unnecessary '{ }' and indents.

Split up the (*open) function and clarify it.

Tidy up the subdevice init in the attach function.

Remove any cruft.

H Hartley Sweeten (14):
  staging: comedi: serial2002: fix different address space sparse warnings
  staging: comedi: serial2002: factor (*poll) busy wait out of tty_read()
  staging: comedi: serial2002: cleanup tty_setspeed()
  staging: comedi: serial2002: cleanup serial_read()
  staging: comedi: serial2002: split up serial_2002_open()
  staging: comedi: serial2002: cleanup serial2002_setup_subdevs()
  staging: comedi: serial2002: don't assume the number of subdevices to detach
  staging: comedi: serial2002: add some whitespace to the subdevice init
  staging: comedi: serial2002: remove attach dev_dbg() noise
  staging: comedi: serial2002: return 0 after successful attach
  staging: comedi: serial2002: hookup the (*open) and (*close) last
  staging: comedi: serial2002: rename all the static functions
  staging: comedi: serial2002: remove pr_err() noise in serial2002_read()
  staging: comedi: serial2002: remove #if 0'ed out code

 drivers/staging/comedi/drivers/serial2002.c | 893 +++++++++++++---------------
 1 file changed, 415 insertions(+), 478 deletions(-)

-- 
1.8.1.4




More information about the devel mailing list