[PATCH 10/15] staging: usbip: simplified cleanup function

Stefan Reif ke42caxa at cip.cs.fau.de
Thu Apr 4 14:03:11 UTC 2013


From: Kurt Kanzenbach <ly80toro at cip.cs.fau.de>

This patch simplified "stub_device_free" cleanup function:
 - changed return type to void, since the return value is
   not checked anywhere
 - kfree is NULL-safe, so removed if statement
 - deleted debug-message

Signed-off-by: Kurt Kanzenbach <ly80toro at cip.cs.fau.de>
Signed-off-by: Stefan Reif <ke42caxa at cip.cs.fau.de>
---
 drivers/staging/usbip/stub_dev.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/drivers/staging/usbip/stub_dev.c b/drivers/staging/usbip/stub_dev.c
index c75ae63..83d629a 100644
--- a/drivers/staging/usbip/stub_dev.c
+++ b/drivers/staging/usbip/stub_dev.c
@@ -327,15 +327,9 @@ static struct stub_device *stub_device_alloc(struct usb_device *udev,
 	return sdev;
 }
 
-static int stub_device_free(struct stub_device *sdev)
+static void stub_device_free(struct stub_device *sdev)
 {
-	if (!sdev)
-		return -EINVAL;
-
 	kfree(sdev);
-	pr_debug("kfree udev ok\n");
-
-	return 0;
 }
 
 /*
-- 
1.8.1




More information about the devel mailing list