[PATCH 12/17] staging: xgifb: XGI_EnableChISLCD(): delete trivial function
Dan Carpenter
dan.carpenter at oracle.com
Mon Apr 1 10:36:29 UTC 2013
On Sat, Mar 30, 2013 at 11:18:08PM +0200, Aaro Koskinen wrote:
> The function returns always false, delete it.
>
> Signed-off-by: Aaro Koskinen <aaro.koskinen at iki.fi>
> ---
> drivers/staging/xgifb/vb_setmode.c | 33 +++++----------------------------
> 1 file changed, 5 insertions(+), 28 deletions(-)
>
> diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c
> index d9e1545..aa1c65a 100644
> --- a/drivers/staging/xgifb/vb_setmode.c
> +++ b/drivers/staging/xgifb/vb_setmode.c
> @@ -4559,23 +4559,6 @@ static unsigned char XGI_IsLCDON(struct vb_device_info *pVBInfo)
> return 0;
> }
>
> -/* --------------------------------------------------------------------- */
> -/* Function : XGI_EnableChISLCD */
> -/* Input : */
> -/* Output : 0 -> Not LCD mode */
> -/* Description : if bool enable = true -> enable, else disable */
> -/* --------------------------------------------------------------------- */
> -static unsigned char XGI_EnableChISLCD(struct vb_device_info *pVBInfo,
> - bool enable)
> -{
> - unsigned short tempbx, tempah;
> -
> - tempbx = 0;
> - tempah = ~((unsigned short) xgifb_reg_get(pVBInfo->Part1Port, 0x2E));
> -
It used to not be false until we stopped checking "tempah" without
explaining why... *grumble* *grumble*. :P
> - return 0;
> -}
regards,
dan carpenter
More information about the devel
mailing list